Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retract v1.5.5 #249

Merged
merged 1 commit into from
Feb 6, 2024
Merged

fix: retract v1.5.5 #249

merged 1 commit into from
Feb 6, 2024

Conversation

black-06
Copy link
Contributor

@black-06 black-06 commented Feb 6, 2024

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

#247, only delete tag v1.5.5 is not enough.
If we accept this mr, we need to publish v1.5.6 to retract v1.5.5 (& v1.5.6)

User Case Description

@jinzhu jinzhu merged commit d715278 into go-gorm:master Feb 6, 2024
1 check passed
@jinzhu
Copy link
Member

jinzhu commented Feb 6, 2024

Can you publish the v1.5.6 tag?

@black-06
Copy link
Contributor Author

black-06 commented Feb 6, 2024

I don't known how to only publish tag....
I only known I can publish a new release with new tag...

@J-Rocke
Copy link

J-Rocke commented Feb 6, 2024

@black-06 I think publishing a new release with the new tag is fine. It could also help to explain what happened to people running into this. From the go module side publishing the git tag without a github release is the same as doing a release with the tag.

@J-Rocke
Copy link

J-Rocke commented Feb 6, 2024

On the commandline you checkout the branch/commit you want to tag and then run: git tag v1.5.6 to create the tag and then git push refs/tags/v1.5.6 to push it to github.

@black-06
Copy link
Contributor Author

black-06 commented Feb 6, 2024

On the commandline you checkout the branch/commit you want to tag and then run: git tag v1.5.6 to create the tag and then git push refs/tags/v1.5.6 to push it to github.

yes I known if i push the git tag to github,it will create a tag without release.

But what surprised me was that 1.5.5 wasn't pushed by me, it seemed like it was automatically generated, or someone else did it on the page

@J-Rocke
Copy link

J-Rocke commented Feb 6, 2024

Sorry i misundestood your question.
I would assume someone else did push the tag.
Maybe you can check some log in github to find out who pushed it.
Or the person who deleted the tag maybe knows since github shows who pushed which tag.

@black-06
Copy link
Contributor Author

black-06 commented Feb 6, 2024

Sorry i misundestood your question. I would assume someone else did push the tag. Maybe you can check some log in github to find out who pushed it. Or the person who deleted the tag maybe knows since github shows who pushed which tag.

I deleted the tag, but that tag shows that I pushed it, just like https://github.com/go-gorm/mysql/releases/tag/v1.5.3.
But I know I didn't...

@J-Rocke
Copy link

J-Rocke commented Feb 6, 2024

Yeah that is strange and you should figure out why that happened.
Is there any reason to not publish the v1.5.6 now?

@black-06
Copy link
Contributor Author

black-06 commented Feb 6, 2024

Yeah that is strange and you should figure out why that happened. Is there any reason to not publish the v1.5.6 now?

Aha, jinzhu manually pushed the tag.

Okay, I publish it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants